Messages in this thread | | | From | Michel Lespinasse <> | Date | Sun, 11 Aug 2019 17:39:23 -0700 | Subject | Re: [PATCH 2/2] mm/vmalloc: use generated callback to populate subtree_max_size |
| |
On Sun, Aug 11, 2019 at 11:46 AM Uladzislau Rezki (Sony) <urezki@gmail.com> wrote: > RB_DECLARE_CALLBACKS_MAX defines its own callback to update the > augmented subtree information after a node is modified. It makes > sense to use it instead of our own propagate implementation. > > Apart of that, in case of using generated callback we can eliminate > compute_subtree_max_size() function and get rid of duplication. > > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
Reviewed-by: Michel Lespinasse <walken@google.com>
Love it. Thanks a lot for the cleanup!
| |