lkml.org 
[lkml]   [2019]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v10 07/15] memory: tegra20-emc: Increase handshake timeout
    Date
    Turned out that it could take over a millisecond under some circumstances,
    like running on a very low CPU/memory frequency. TRM says that handshake
    happens when there is a "safe" moment, but not explains exactly what that
    moment is. Apparently at least memory should be idling and thus the low
    frequency should be a reasonable cause for a longer handshake delay.

    Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
    ---
    drivers/memory/tegra/tegra20-emc.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/memory/tegra/tegra20-emc.c b/drivers/memory/tegra/tegra20-emc.c
    index 25a6aad6a7a9..da75efc632c7 100644
    --- a/drivers/memory/tegra/tegra20-emc.c
    +++ b/drivers/memory/tegra/tegra20-emc.c
    @@ -236,7 +236,7 @@ static int emc_complete_timing_change(struct tegra_emc *emc, bool flush)
    }

    timeout = wait_for_completion_timeout(&emc->clk_handshake_complete,
    - usecs_to_jiffies(100));
    + msecs_to_jiffies(100));
    if (timeout == 0) {
    dev_err(emc->dev, "EMC-CAR handshake failed\n");
    return -EIO;
    --
    2.22.0
    \
     
     \ /
      Last update: 2019-08-11 23:03    [W:3.851 / U:0.320 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site