lkml.org 
[lkml]   [2019]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 4/5] posix-cpu-timers: Defer timer handling to task_work
    On 08/01, Thomas Gleixner wrote:
    >
    > +static void __run_posix_cpu_timers(struct task_struct *tsk)
    > +{
    > + /* FIXME: Init it proper in fork or such */
    > + init_task_work(&tsk->cpu_timer_work, posix_cpu_timers_work);
    > + task_work_add(tsk, &tsk->cpu_timer_work, true);
    > +}

    What if update_process_times/run_posix_cpu_timers is called again before
    this task does task_work_run() ?

    somehow it should check that ->cpu_timer_work is not already queued...

    Or suppose that this is called when task_work_run() executes this
    cpu_timer_work. Looks like you need another flag checked by
    __run_posix_cpu_timers() and cleare in posix_cpu_timers_work() ?

    Oleg.

    \
     
     \ /
      Last update: 2019-08-01 17:40    [W:2.222 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site