lkml.org 
[lkml]   [2019]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] drm/vgem: fix cache synchronization on arm/arm64
    On Thu, Aug 1, 2019 at 5:40 AM Chris Wilson <chris@chris-wilson.co.uk> wrote:
    >
    > Quoting Sean Paul (2019-07-31 20:23:31)
    > > On Fri, Jul 19, 2019 at 11:21:53AM +0200, Daniel Vetter wrote:
    > > > On Wed, Jul 17, 2019 at 02:15:37PM -0700, Rob Clark wrote:
    > > > > From: Rob Clark <robdclark@chromium.org>
    > > > >
    > > > > drm_cflush_pages() is no-op on arm/arm64. But instead we can use
    > > > > dma_sync API.
    > > > >
    > > > > Fixes failures w/ vgem_test.
    > > > >
    > > > > Signed-off-by: Rob Clark <robdclark@chromium.org>
    > > > > ---
    > > > > An alternative approach to the series[1] I sent yesterday
    > > > >
    > > > > On the plus side, it keeps the WC buffers and avoids any drm core
    > > > > changes. On the minus side, I don't think it will work (at least
    > > > > on arm64) prior to v5.0[2], so the fix can't be backported very
    > > > > far.
    > > >
    > > > Yeah seems a lot more reasonable.
    > > >
    > > > Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
    > >
    > > Applied to drm-misc-fixes, thanks!
    >
    > But it didn't actually fix the failures in CI.

    Hmm, that is unfortunate, I'd assumed that silence meant latest
    version was working in CI..

    dma_sync_sg_* doesn't work on x86? It would be kinda unfortunate to
    have vgem only work on x86 *or* arm.. maybe bringing back
    drm_cflush_pages() could make it work in both cases

    BR,
    -R

    \
     
     \ /
      Last update: 2019-08-01 17:19    [W:6.186 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site