Messages in this thread | | | Date | Fri, 12 Jul 2019 18:06:36 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH] padata: use smp_mb in padata_reorder to avoid orphaned padata jobs |
| |
Daniel Jordan <daniel.m.jordan@oracle.com> wrote: > > CPU0 CPU1 > > padata_reorder padata_do_serial > LOAD reorder_objects // 0 > INC reorder_objects // 1 > padata_reorder > TRYLOCK pd->lock // failed > UNLOCK pd->lock
I think this can't happen because CPU1 won't call padata_reorder at all as it's the wrong CPU so it gets pushed back onto a work queue which will go back to CPU0.
Steffen, could you please take a look at this as there clearly is a problem here?
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |