Messages in this thread | | | Date | Wed, 26 Jun 2019 12:45:25 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH 1/2] net: stmmac: Fix possible deadlock when disabling EEE support |
| |
On Wed, Jun 26, 2019 at 11:23:21AM +0100, Jon Hunter wrote: > When stmmac_eee_init() is called to disable EEE support, then the timer > for EEE support is stopped and we return from the function. Prior to > stopping the timer, a mutex was acquired but in this case it is never > released and so could cause a deadlock. Fix this by releasing the mutex > prior to returning from stmmax_eee_init() when stopping the EEE timer. > > Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic") > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + > 1 file changed, 1 insertion(+)
Tested-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] | |