lkml.org 
[lkml]   [2019]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 3/3] oom: decouple mems_allowed from oom_unkillable_task
On Wed 26-06-19 17:12:10, Hillf Danton wrote:
>
> On Mon, 24 Jun 2019 14:27:11 -0700 (PDT) Shakeel Butt wrote:
> >
> > @@ -1085,7 +1091,8 @@ bool out_of_memory(struct oom_control *oc)
> > check_panic_on_oom(oc, constraint);
> >
> > if (!is_memcg_oom(oc) && sysctl_oom_kill_allocating_task &&
> > - current->mm && !oom_unkillable_task(current, oc->nodemask) &&
> > + current->mm && !oom_unkillable_task(current) &&
> > + has_intersects_mems_allowed(current, oc) &&
> For what?

This is explained in the changelog I believe - see the initial section
about the history and motivation for the check. This patch removes it
from oom_unkillable_task so we have to check it explicitly here.

> > current->signal->oom_score_adj != OOM_SCORE_ADJ_MIN) {
> > get_task_struct(current);
> > oc->chosen = current;
> > --
> > 2.22.0.410.gd8fdbe21b5-goog

--
Michal Hocko
SUSE Labs

\
 
 \ /
  Last update: 2019-06-26 11:18    [W:0.075 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site