lkml.org 
[lkml]   [2019]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v7 11/13] ARM: dts: exynos: add syscon to clock compatible
    From
    Date

    On 5/8/19 12:17 PM, Krzysztof Kozlowski wrote:
    > On Wed, 8 May 2019 at 11:50, Lukasz Luba <l.luba@partner.samsung.com> wrote:
    >>
    >>
    >> On 5/8/19 9:22 AM, Krzysztof Kozlowski wrote:
    >>> On Mon, 6 May 2019 at 17:12, Lukasz Luba <l.luba@partner.samsung.com> wrote:
    >>>>
    >>>> In order get the clock by phandle and use it with regmap it needs to be
    >>>> compatible with syscon. The DMC driver uses two registers from clock
    >>>> register set and needs the regmap of them.
    >>>>
    >>>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
    >>>> ---
    >>>> arch/arm/boot/dts/exynos5800.dtsi | 2 +-
    >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
    >>>>
    >>>> diff --git a/arch/arm/boot/dts/exynos5800.dtsi b/arch/arm/boot/dts/exynos5800.dtsi
    >>>> index 57d3b31..0a2b328 100644
    >>>> --- a/arch/arm/boot/dts/exynos5800.dtsi
    >>>> +++ b/arch/arm/boot/dts/exynos5800.dtsi
    >>>> @@ -17,7 +17,7 @@
    >>>> };
    >>>>
    >>>> &clock {
    >>>> - compatible = "samsung,exynos5800-clock";
    >>>> + compatible = "samsung,exynos5800-clock", "syscon";
    >>>
    >>> What about Exynos5420 DTSI?
    >> OK, I will also add it to 5420 dtsi.
    >> --------------------------8<------------------------------------------
    >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi
    >> b/arch/arm/boot/dts/exynos5420.dtsi
    >> index aaff158..d9203f0 100644
    >> --- a/arch/arm/boot/dts/exynos5420.dtsi
    >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
    >> @@ -173,7 +173,7 @@
    >> };
    >>
    >> clock: clock-controller@10010000 {
    >> - compatible = "samsung,exynos5420-clock";
    >> + compatible = "samsung,exynos5420-clock", "syscon";
    >> reg = <0x10010000 0x30000>;
    >> #clock-cells = <1>;
    >> };
    >> diff --git a/arch/arm/boot/dts/exynos5800.dtsi
    >> b/arch/arm/boot/dts/exynos5800.dtsi
    >> index 57d3b31..0a2b328 100644
    >> --- a/arch/arm/boot/dts/exynos5800.dtsi
    >> +++ b/arch/arm/boot/dts/exynos5800.dtsi
    >> @@ -17,7 +17,7 @@
    >> };
    >>
    >> &clock {
    >> - compatible = "samsung,exynos5800-clock";
    >> + compatible = "samsung,exynos5800-clock", "syscon";
    >> };
    >> ----------------------------->8-----------------------------------
    >>
    >> Can I add your ack after that?
    >
    > No need for ack. The DTS have to go through arm-soc so I will pick it
    > up when dependencies get in and bindings are accepted (acked or
    > applied). We have now merge window so I guess this will go to v5.4-rc1
    > at earliest.
    >
    > If you want to speed up things in future, be sure that dependencies
    > (headers) are applied as early as possible.
    Thank you Krzysztof for the explanation, good to know that.

    Regards,
    Lukasz
    >
    > Best regards,
    > Krzysztof
    >
    >

    \
     
     \ /
      Last update: 2019-05-08 15:14    [W:5.350 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site