lkml.org 
[lkml]   [2019]   [May]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Subject[PATCH v2 0/7] Hexdump Enhancements
    Date
    From: Alastair D'Silva <alastair@d-silva.org>

    Apologies for the large CC list, it's a heads up for those responsible
    for subsystems where a prototype change in generic code causes a change
    in those subsystems.

    This series enhances hexdump.

    These improve the readability of the dumped data in certain situations
    (eg. wide terminals are available, many lines of empty bytes exist, etc).

    The default behaviour of hexdump is unchanged, however, the prototype
    for hex_dump_to_buffer() has changed, and print_hex_dump() has been
    renamed to print_hex_dump_ext(), with a wrapper replacing it for
    compatibility with existing code, which would have been too invasive to
    change.

    Hexdump selftests have be run & confirmed passed.

    Changelog:
    - Fix failing selftests
    - Fix precedence bug in 'Replace ascii bool in hex_dump_to_buffer...'
    - Remove hardcoded new lengths & instead relax the checks in
    hex_dump_to_buffer, allocating the buffer from the heap instead of the
    stack.
    - Replace the skipping of lines of 0x00/0xff with skipping lines of
    repeated characters, announcing what has been skipped.
    - Add spaces as an optional N-group separator
    - Allow byte ordering to be maintained when HEXDUMP_RETAIN_BYTE_ORDERING
    is set.
    - Updated selftests to cover 'Relax rowsize checks' &
    'Optionally retain byte ordering'

    Alastair D'Silva (7):
    lib/hexdump.c: Fix selftests
    lib/hexdump.c: Relax rowsize checks in hex_dump_to_buffer
    lib/hexdump.c: Optionally suppress lines of repeated bytes
    lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags
    lib/hexdump.c: Allow multiple groups to be separated by lines '|'
    lib/hexdump.c: Allow multiple groups to be separated by spaces
    lib/hexdump.c: Optionally retain byte ordering

    drivers/gpu/drm/i915/intel_engine_cs.c | 2 +-
    drivers/isdn/hardware/mISDN/mISDNisar.c | 6 +-
    drivers/mailbox/mailbox-test.c | 2 +-
    drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
    .../net/ethernet/synopsys/dwc-xlgmac-common.c | 2 +-
    drivers/net/wireless/ath/ath10k/debug.c | 3 +-
    .../net/wireless/intel/iwlegacy/3945-mac.c | 2 +-
    drivers/platform/chrome/wilco_ec/debugfs.c | 2 +-
    drivers/scsi/scsi_logging.c | 8 +-
    drivers/staging/fbtft/fbtft-core.c | 2 +-
    fs/seq_file.c | 3 +-
    include/linux/printk.h | 34 ++-
    lib/hexdump.c | 260 +++++++++++++++---
    lib/test_hexdump.c | 146 +++++++---
    14 files changed, 372 insertions(+), 102 deletions(-)

    --
    2.21.0

    \
     
     \ /
      Last update: 2019-05-08 09:05    [W:5.423 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site