lkml.org 
[lkml]   [2019]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 08/13] PCI/portdrv: Simplify PCIe feature permission checking
On Tue, May 07, 2019 at 01:00:03PM +0100, David Woodhouse wrote:
> On Fri, 2018-03-09 at 13:00 -0600, Bjorn Helgaas wrote:
> > --- a/drivers/pci/probe.c
> > +++ b/drivers/pci/probe.c
> > @@ -540,6 +540,16 @@ struct pci_host_bridge *pci_alloc_host_bridge(size_t priv)
> > INIT_LIST_HEAD(&bridge->windows);
> > bridge->dev.release = pci_release_host_bridge_dev;
> >
> > + /*
> > + * We assume we can manage these PCIe features. Some systems may
> > + * reserve these for use by the platform itself, e.g., an ACPI BIOS
> > + * may implement its own AER handling and use _OSC to prevent the
> > + * OS from interfering.
> > + */
> > + bridge->use_aer = 1;
> > + bridge->use_hotplug = 1;
> > + bridge->use_pme = 1;
> > +
> > return bridge;
> > }
> > EXPORT_SYMBOL(pci_alloc_host_bridge);
>
> Is there a good reason why you've done this only for
> pci_alloc_host_bridge() and not also for devm_pci_alloc_host_bridge()?

No good reason; I just screwed up. Should be fixed in v5.2 (and marked for
stable):

https://lore.kernel.org/linux-pci/20190318160718.10925-1-jean-philippe.brucker@arm.com

Sorry about that.

Bjorn

\
 
 \ /
  Last update: 2019-05-07 14:50    [W:0.107 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site