Messages in this thread | | | Subject | Re: [PATCH 2/3] power: supply: Add driver for Microchip UCS1002 | From | Lucas Stach <> | Date | Fri, 26 Apr 2019 16:43:44 +0200 |
| |
Hi Andrey,
Am Mittwoch, den 17.04.2019, 01:44 -0700 schrieb Andrey Smirnov: > Add driver for Microchip UCS1002 Programmable USB Port Power > Controller with Charger Emulation. The driver exposed a power supply > device to control/monitor various parameter of the device as well as a > regulator to allow controlling VBUS line. > > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > > Cc: Chris Health <cphealy@gmail.com> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Fabio Estevam <fabio.estevam@nxp.com> > > Cc: Guenter Roeck <linux@roeck-us.net> > > Cc: Sebastian Reichel <sre@kernel.org> > Cc: linux-kernel@vger.kernel.org > Cc: linux-pm@vger.kernel.org > --- [...] > + if (irq_a_det > 0) { > > + ret = devm_request_threaded_irq(dev, irq_a_det, NULL, > > + ucs1002_charger_irq, > > + IRQF_TRIGGER_FALLING | > > + IRQF_TRIGGER_RISING | > > + IRQF_ONESHOT, > > + "ucs1002-a_det", info); > > + if (ret) { > > + dev_err(dev, "failed to request A_DET threaded irq\n"); > > + return ret; > > + } > > + } > + > > + if (irq_alert > 0) { > > + ret = devm_request_threaded_irq(dev, irq_alert, NULL, > > + ucs1002_alert_irq, > > + IRQF_TRIGGER_FALLING | > > + IRQF_TRIGGER_RISING | > > + IRQF_ONESHOT, > > + "ucs1002-alert", info); > > + if (ret) { > > + dev_err(dev, "failed to request ALERT threaded irq\n"); > > + return ret; > > + } > > + }
Any reason to explicitly set the IRQ trigger type here? Normally I would expect this to be set via the DT interrupt specifier.
Regards, Lucas
| |