lkml.org 
[lkml]   [2019]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] lib: add __sysfs_match_string_with_gaps() helper
    On Fri, Apr 26, 2019 at 12:29:11PM +0300, Alexandru Ardelean wrote:

    > Hmm, I actually did not give much thought to that -1.
    > I'll check into this and see about a V3.
    > It may make more sense to just fix the original
    > `__sysfs_match_string()`, but I'll need to go through the users of
    > this function and see.

    I was thinking about existing users of such (with "gaps") cases.
    Not all of them have NULL there and would like to avoid some members.
    Though, I think that we may ignore NULL items if -1 is supplied.

    Think as well about ARRAY_SIZE() as given to that.

    And consider to fix match_string() accordingly.

    --
    With Best Regards,
    Andy Shevchenko


    \
     
     \ /
      Last update: 2019-04-26 16:28    [W:3.494 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site