lkml.org 
[lkml]   [2019]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] panic: make panic start/end messages consistent
On Fri 2019-04-26 15:33:56, Sergey Senozhatsky wrote:
> We don't have consistency:
> - we always print panic header
> pr_emerg("Kernel panic - not syncing:")
>
> - but we don't always print panic footer
> pr_emerg("---[ end Kernel panic - not syncing:")
>
> For instance, no panic footer (end panic) message will be
> printed when panic_timeout is set - the kernel will either
> reboot immediately after console_flush_on_panic() (emergency
> restart) or after panic_timeout seconds. Additionally,
> panic_print_sys_info() goes before panic footer line, which
> doesn't look very right, panic_print_sys_info() is just
> additional debugging into.
>
> Let's make it consistent:
>
> pr_emerg("Kernel panic - not syncing:")
> dump_stack();
> console_flush_on_panic();
> pr_emerg("---[ end Kernel panic - not syncing:")
>
> panic_print_sys_info();
> /* the rest */
> /* panic_timeout handling */
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Makes sense to me:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

\
 
 \ /
  Last update: 2019-04-26 10:42    [W:0.051 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site