Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH v3 1/3] clk: analogbits: add Wide-Range PLL library | Date | Fri, 26 Apr 2019 18:01:51 -0700 |
| |
Quoting Paul Walmsley (2019-04-11 01:27:32) > Add common library code for the Analog Bits Wide-Range PLL (WRPLL) IP > block, as implemented in TSMC CLN28HPC. > > There is no bus interface or register target associated with this PLL. > This library is intended to be used by drivers for IP blocks that > expose registers connected to the PLL configuration and status > signals. > > Based on code originally written by Wesley Terpstra > <wesley@sifive.com>: > https://github.com/riscv/riscv-linux/commit/999529edf517ed75b56659d456d221b2ee56bb60 > > This version incorporates several changes requested by Stephen > Boyd <sboyd@kernel.org>. > > Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com> > Signed-off-by: Paul Walmsley <paul@pwsan.com> > Cc: Wesley Terpstra <wesley@sifive.com> > Cc: Palmer Dabbelt <palmer@sifive.com> > Cc: Michael Turquette <mturquette@baylibre.com> > Cc: Stephen Boyd <sboyd@kernel.org> > Cc: Megan Wachs <megan@sifive.com> > Cc: linux-clk@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > ---
I haven't deeply reviewed at all, but I already get two problems when compile testing these patches. I can fix them up if nothing else needs fixing.
drivers/clk/analogbits/wrpll-cln28hpc.c:165 __wrpll_calc_divq() warn: should 'target_rate << divq' be a 64 bit type? drivers/clk/sifive/fu540-prci.c:214:16: error: return expression in void function
| |