Messages in this thread | | | Subject | Re: [PATCH] Bluetooth: hci_qca: Fix crash with non-serdev devices | From | Marcel Holtmann <> | Date | Tue, 23 Apr 2019 21:38:36 +0200 |
| |
Hi Matthias,
> qca_set_baudrate() calls serdev_device_wait_until_sent() assuming that > the HCI is always associated with a serdev device. This isn't true for > ROME controllers instantiated through ldisc, where the call causes a > crash due to a NULL pointer dereferentiation. Only call the function > when we have a serdev device. The timeout for ROME devices at the end > of qca_set_baudrate() is long enough to be reasonably sure that the > command was sent. > > Fixes: fa9ad876b8e0 ("Bluetooth: hci_qca: Add support for Qualcomm Bluetooth chip wcn3990") > Reported-by: Balakrishna Godavarthi <bgodavar@codeaurora.org> > Reported-by: Rocky Liao <rjliao@codeaurora.org> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > Reviewed-by: Rocky Liao <rjliao@codeaurora.org> > Tested-by: Rocky Liao <rjliao@codeaurora.org> > Reviewed-by: Balakrishna Godavarthi <bgodavar@codeaurora.org> > --- > Changes in v2: > - first version got corrupted for some reason, this should apply > - added 'Reviewed-by' tags from Rocky abd Balakrishna > - added 'Tested-by' tag from Rocky > --- > drivers/bluetooth/hci_qca.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
| |