Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 23 Apr 2019 12:44:55 +0200 | Subject | Re: [PATCH 4/6] ARM: ks8695: move gpio code back into platform |
| |
On Mon, Apr 15, 2019 at 10:27 PM Arnd Bergmann <arnd@arndb.de> wrote:
> Properly splitting this out into a portable driver is > hard, as the gpio code tightly interacts with the irqchip > code. Give up and move it back to its original location, > but make the headers private in the process. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
I bet a million to one it "just" needs to be reworked into a hierarchical interrupt controller with the GPIO at the level below the irqchip adding level semantics.
I did provide an example of how to do this in the ixp4xx patchset, but if you don't have the hardware at hand I would not recommend trying it.
With the goal of getting a better build for ARM32 maintenance I think this is a lesser evil, so: Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |