Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [alsa-devel] [PATCH v3 2/5] soundwire: fix style issues | From | Pierre-Louis Bossart <> | Date | Wed, 17 Apr 2019 12:18:22 -0500 |
| |
>>>> diff --git a/drivers/soundwire/Kconfig b/drivers/soundwire/Kconfig >>>> index 19c8efb9a5ee..84876a74874f 100644 >>>> --- a/drivers/soundwire/Kconfig >>>> +++ b/drivers/soundwire/Kconfig >>>> @@ -4,7 +4,7 @@ >>>> >>>> menuconfig SOUNDWIRE >>>> bool "SoundWire support" >>>> - ---help--- >>>> + help >>> >>> Not sure if this is a style issue, kernel seems to have 2990 instances >>> of this! >> >> this is reported by checkpatch.pl --strict. > > Please don't run checkpatch on code that's already in the kernel, and > especially not with the --strict (a.k.a. --subjective) option enabled. > > Don't try to fix what isn't broken.
I would agree in general, but this case is different: the SoundWire code in the upstream kernel is missing parts left and right and isn't fully functional as is. I will soon be posting what's missing, so this cleanup is an opportunity to bring SoundWire to the latest coding standards before adding the missing pieces which will be compliant with --strict. For the record using --strict already exposed 3 major issues in the yet-to-be-released code, so it's not as subjective as you describe it.
| ![\](/images/icornerr.gif) |