Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 16 Apr 2019 21:03:20 -0700 (PDT) | Subject | Re: [PATCH net-next] xen-netfront: mark expected switch fall-through | From | David Miller <> |
| |
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> Date: Mon, 15 Apr 2019 16:11:41 -0500
> In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/net/xen-netfront.c: In function ‘netback_changed’: > drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (dev->state == XenbusStateClosed) > ^ > drivers/net/xen-netfront.c:2041:2: note: here > case XenbusStateClosing: > ^~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > Notice that, in this particular case, the code comment is modified > in accordance with what GCC is expecting to find. > > This patch is part of the ongoing efforts to enable > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Applied.
| ![\](/images/icornerr.gif) |