Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v11 3/7] anybus-s: support the Arcx anybus controller | From | "Enrico Weigelt, metux IT consult" <> | Date | Wed, 17 Apr 2019 10:39:03 +0200 |
| |
On 16.04.19 23:23, Sven Van Asbroeck wrote:
Hi,
> Well yes, we could treat it as an mfd device, with a common register accessor,> which registers anybus-s host and adc drivers, all selectable via> Kconfig / defconfig... But that's a lot of extra code just to handle one single> bit in a register, which is a boolean input.> > Can be done but is it worth it? hmm, I think the main question here is clean separation between subsystems - devices that span multiple subsystems, IMHO, fall into the category "mfd".
separate drivers probably don't make much sense here, but maybe a CONFIG_ flag for disabling this functionality ?
>> Does this power read-out involve some CAN traffic, or is it just >> fetching from some card that just happens to be some CAN interface ? >> (IOW: is cansocket needed for that ?) > > It is purely a boolean input. The boolean output of a voltage monitor chip. > When our hardware is assembled, the voltage monitor input is connected > to a signal which indicates the CAN status. In theory, it could be connected > to the factory's light switch. It would then read out the status of the factory > floor lights. It has no CAN functionality whatsoever.
hmm, wouldn't the input subsystem be more appropriate for that ?
--mtx
-- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
| ![\](/images/icornerr.gif) |