Messages in this thread | | | Date | Thu, 18 Apr 2019 00:47:24 +0200 (CEST) | From | Thomas Gleixner <> | Subject | Re: [PATCH v7 15/21] x86/split_lock: Add a sysfs interface to enable/disable split lock detection during run time |
| |
On Wed, 17 Apr 2019, Fenghua Yu wrote:
> The interface /sys/device/system/cpu/split_lock_detect is added > to allow user to control split lock detection and show current split > lock detection setting. > > Writing [yY1] or [oO][nN] to the file enables split lock detection and > writing [nN0] or [oO][fF] disables split lock detection. Split lock > detection is enabled or disabled on all CPUs. > > Reading the file returns current global split lock detection setting: > 0: disabled > 1: enabled
Again, You explain WHAT this patch does and still there is zero justification why this sysfs knob is needed at all. I still do not see any reason why this knob should exist.
Thanks,
tglx
| |