Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 17 Apr 2019 23:18:32 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v2 06/16] watchdog: hpwdt: drop warning after calling watchdog_init_timeout |
| |
> > I have the following diff applied on top of patch 2. Works with and > > without a parent device. I am not super happy casting 'identity' but > > since its u8-type is exported to userspace, I think we can't avoid it. > > Guenter, is this cast safe? Here is the diff: > > > I would think it is safe, but question is if it is it needed - ie do you see > a warning if it isn't there ? Presumably yes; if so, let's just do it.
Yes, the compiler rightfully complains otherwise.
Do you prefer resending only patch 2 or the whole series?
[unhandled content-type:application/pgp-signature]
| ![\](/images/icornerr.gif) |