Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: pseries/energy: Use OF accessor functions to read ibm, drc-indexes | Date | Sun, 31 Mar 2019 21:13:02 +1100 (AEDT) |
| |
On Fri, 2019-03-08 at 15:33:24 UTC, "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" <ego@linux.vnet.ibm.com> > > In cpu_to_drc_index() in the case when FW_FEATURE_DRC_INFO is absent, > we currently use of_read_property() to obtain the pointer to the array > corresponding to the property "ibm,drc-indexes". The elements of this > array are of type __be32, but are accessed without any conversion to > the OS-endianness, which is buggy on a Little Endian OS. > > Fix this by using of_property_read_u32_index() accessor function to > safely read the elements of the array. > > Fixes: commit e83636ac3334 ("pseries/drc-info: Search DRC properties for CPU indexes") > Cc: <stable@vger.kernel.org> #v4.16+ > Reported-by: Pavithra R. Prakash <pavrampu@in.ibm.com> > Signed-off-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com> > Reviewed-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/ce9afe08e71e3f7d64f337a6e932e508
cheers
| |