lkml.org 
[lkml]   [2019]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/7] cpufreq: ap806: fix possible object reference leak
    Date
    The call to of_find_compatible_node returns a node pointer with refcount
    incremented thus it must be explicitly decremented after the last
    usage.

    Detected by coccinelle with the following warnings:
    ./drivers/cpufreq/armada-8k-cpufreq.c:187:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 130, but without a corresponding object release within this function.
    ./drivers/cpufreq/armada-8k-cpufreq.c:191:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 130, but without a corresponding object release within this function.

    Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
    Cc: Jason Cooper <jason@lakedaemon.net>
    Cc: Andrew Lunn <andrew@lunn.ch>
    Cc: Gregory Clement <gregory.clement@bootlin.com>
    Cc: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
    Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
    Cc: Viresh Kumar <viresh.kumar@linaro.org>
    Cc: linux-arm-kernel@lists.infradead.org
    Cc: linux-pm@vger.kernel.org
    Cc: linux-kernel@vger.kernel.org
    ---
    drivers/cpufreq/armada-8k-cpufreq.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/cpufreq/armada-8k-cpufreq.c b/drivers/cpufreq/armada-8k-cpufreq.c
    index b3f4bd6..988ebc3 100644
    --- a/drivers/cpufreq/armada-8k-cpufreq.c
    +++ b/drivers/cpufreq/armada-8k-cpufreq.c
    @@ -132,6 +132,7 @@ static int __init armada_8k_cpufreq_init(void)
    of_node_put(node);
    return -ENODEV;
    }
    + of_node_put(node);

    nb_cpus = num_possible_cpus();
    freq_tables = kcalloc(nb_cpus, sizeof(*freq_tables), GFP_KERNEL);
    --
    2.9.5
    \
     
     \ /
      Last update: 2019-04-01 03:39    [W:5.190 / U:0.372 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site