Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH v2] drivers/staging: Fix styling of the comment related to SPDX-License-Identifier in vt6656/*.h | From | Mukesh Ojha <> | Date | Sun, 31 Mar 2019 17:57:06 +0530 |
| |
On 3/31/2019 5:49 PM, Mukesh Ojha wrote: > > On 3/31/2019 2:44 PM, Ojaswin Mujoo wrote: >> Fix checkpatch.pl styling error related to SPDX-License-Identifier >> comment in vt6656/*.h >> * v2: fix patch styling > Above line should be after ---. >> >> Signed-off-by: Ojaswin Mujoo <ojaswin25111998@gmail.com> > > Although, it looks ok to me. but this is spread through out the tree > and a result of a copy paste. > > Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> > > But, i would want other to comment on this, whether we really want > this kind of effort coming forward. > > or can it be not done by some scripting?
Found the discussion and the script at https://lkml.org/lkml/2019/2/7/46.
Let's do that.
> > > Cheers, > -Mukesh > > >> --- >> drivers/staging/vt6656/baseband.h | 2 +- >> drivers/staging/vt6656/card.h | 2 +- >> drivers/staging/vt6656/channel.h | 2 +- >> drivers/staging/vt6656/desc.h | 2 +- >> drivers/staging/vt6656/device.h | 2 +- >> drivers/staging/vt6656/dpc.h | 2 +- >> drivers/staging/vt6656/firmware.h | 2 +- >> drivers/staging/vt6656/int.h | 2 +- >> drivers/staging/vt6656/key.h | 2 +- >> drivers/staging/vt6656/power.h | 2 +- >> drivers/staging/vt6656/rf.h | 2 +- >> drivers/staging/vt6656/rxtx.h | 2 +- >> drivers/staging/vt6656/usbpipe.h | 2 +- >> drivers/staging/vt6656/wcmd.h | 2 +- >> 14 files changed, 14 insertions(+), 14 deletions(-) >> >> diff --git a/drivers/staging/vt6656/baseband.h >> b/drivers/staging/vt6656/baseband.h >> index a907e30..c3b8bbd 100644 >> --- a/drivers/staging/vt6656/baseband.h >> +++ b/drivers/staging/vt6656/baseband.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/card.h >> b/drivers/staging/vt6656/card.h >> index 0a91d9b..75cd340 100644 >> --- a/drivers/staging/vt6656/card.h >> +++ b/drivers/staging/vt6656/card.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/channel.h >> b/drivers/staging/vt6656/channel.h >> index 6d0d282..cca330f 100644 >> --- a/drivers/staging/vt6656/channel.h >> +++ b/drivers/staging/vt6656/channel.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/desc.h >> b/drivers/staging/vt6656/desc.h >> index ac45ebb..3a83a9e 100644 >> --- a/drivers/staging/vt6656/desc.h >> +++ b/drivers/staging/vt6656/desc.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/device.h >> b/drivers/staging/vt6656/device.h >> index a2feeb9..6074ced 100644 >> --- a/drivers/staging/vt6656/device.h >> +++ b/drivers/staging/vt6656/device.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/dpc.h b/drivers/staging/vt6656/dpc.h >> index ddd0cb7..e080add 100644 >> --- a/drivers/staging/vt6656/dpc.h >> +++ b/drivers/staging/vt6656/dpc.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/firmware.h >> b/drivers/staging/vt6656/firmware.h >> index f30ae90..161126f 100644 >> --- a/drivers/staging/vt6656/firmware.h >> +++ b/drivers/staging/vt6656/firmware.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/int.h b/drivers/staging/vt6656/int.h >> index 1e6ff92..987c454e9 100644 >> --- a/drivers/staging/vt6656/int.h >> +++ b/drivers/staging/vt6656/int.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/key.h b/drivers/staging/vt6656/key.h >> index 1306ff4..918c07c 100644 >> --- a/drivers/staging/vt6656/key.h >> +++ b/drivers/staging/vt6656/key.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/power.h >> b/drivers/staging/vt6656/power.h >> index d5a3198..58755ae 100644 >> --- a/drivers/staging/vt6656/power.h >> +++ b/drivers/staging/vt6656/power.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/rf.h b/drivers/staging/vt6656/rf.h >> index f77866a..6103117 100644 >> --- a/drivers/staging/vt6656/rf.h >> +++ b/drivers/staging/vt6656/rf.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/rxtx.h >> b/drivers/staging/vt6656/rxtx.h >> index 44698f4..d528607 100644 >> --- a/drivers/staging/vt6656/rxtx.h >> +++ b/drivers/staging/vt6656/rxtx.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/usbpipe.h >> b/drivers/staging/vt6656/usbpipe.h >> index 5d7708f..2910ca5 100644 >> --- a/drivers/staging/vt6656/usbpipe.h >> +++ b/drivers/staging/vt6656/usbpipe.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved. >> diff --git a/drivers/staging/vt6656/wcmd.h >> b/drivers/staging/vt6656/wcmd.h >> index 4a96f4d..a0d98cf 100644 >> --- a/drivers/staging/vt6656/wcmd.h >> +++ b/drivers/staging/vt6656/wcmd.h >> @@ -1,4 +1,4 @@ >> -// SPDX-License-Identifier: GPL-2.0+ >> +/* SPDX-License-Identifier: GPL-2.0+ */ >> /* >> * Copyright (c) 1996, 2003 VIA Networking Technologies, Inc. >> * All rights reserved.
| ![\](/images/icornerr.gif) |