Messages in this thread | | | Subject | Re: [PATCH 10/25] coresight: tpiu: Clean up device specific data | From | Suzuki K Poulose <> | Date | Wed, 27 Mar 2019 11:52:54 +0000 |
| |
On 03/26/2019 09:54 PM, Mathieu Poirier wrote: > On Wed, Mar 20, 2019 at 06:49:27PM +0000, Suzuki K Poulose wrote: >> Switch to using the coresight device instead of the parent >> amba device. >> >> Cc: Mathieu Poirier <mathieu.poirier@linaro.org> >> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> --- >> drivers/hwtracing/coresight/coresight-tpiu.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c >> index b2f72a1..9763721 100644 >> --- a/drivers/hwtracing/coresight/coresight-tpiu.c >> +++ b/drivers/hwtracing/coresight/coresight-tpiu.c >> @@ -48,15 +48,13 @@ >> >> /** >> * @base: memory mapped base address for this component. >> - * @dev: the device entity associated to this component. >> + * @dev: the coresight device entity associated to this component. >> * @atclk: optional clock for the core parts of the TPIU. >> - * @csdev: component vitals needed by the framework. >> */ >> struct tpiu_drvdata { >> void __iomem *base; >> struct device *dev; >> struct clk *atclk; >> - struct coresight_device *csdev; > > Here again I would get rid of @dev rather than @csdev to be consistent with what > was done previously.
Sure, will do.
Cheers Suzuki
| |