Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 27 Mar 2019 16:15:23 -0700 | Subject | Re: [PATCH] MIPS: KGDB: fix kgdb support for SMP platforms. |
| |
Hi,
On Wed, Mar 27, 2019 at 4:08 PM Chong Qiao <qiaochong@loongson.cn> wrote: > > KGDB_call_nmi_hook is called by other cpu through smp call. > MIPS smp call is processed in ipi irq handler and regs is saved in > handle_int. > So kgdb_call_nmi_hook get regs by get_irq_regs and regs will be passed > to kgdb_cpu_enter. > > Signed-off-by: Chong Qiao <qiaochong@loongson.cn>
Since you didn't really change any content, you could have just carried my previous review. In any case I'll add my tag again:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I'd also note that it's nice if you version your patches and include version history. If you need help you might consider using patman to help you send upstream patches. See:
http://git.denx.de/?p=u-boot.git;a=blob;f=tools/patman/README
...never mind that it lives in the U-Boot tree--it's great for kernel work too.
Thanks for contributing to the kernel! :-)
-Doug
| |