lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 123/192] drm: rcar-du: add missing of_node_put
    Date
    From: Julia Lawall <julia.lawall@lip6.fr>

    [ Upstream commit 4c6d8fc20b09f9684743afd72e4dbc3f15524479 ]

    Add an of_node_put when the result of of_graph_get_remote_port_parent is
    not available.

    Add a second of_node_put if no encoder is selected (encoder remains NULL).

    The semantic match that finds the first problem is as follows
    (http://coccinelle.lip6.fr):

    // <smpl>
    @r exists@
    local idexpression e;
    expression x;
    @@
    e = of_graph_get_remote_port_parent(...);
    ... when != x = e
    when != true e == NULL
    when != of_node_put(e)
    when != of_fwnode_handle(e)
    (
    return e;
    |
    *return ...;
    )
    // </smpl>

    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
    Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
    index fb46df56f0c4..0386b454e221 100644
    --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
    +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
    @@ -300,6 +300,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
    dev_dbg(rcdu->dev,
    "connected entity %pOF is disabled, skipping\n",
    entity);
    + of_node_put(entity);
    return -ENODEV;
    }

    @@ -335,6 +336,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
    dev_warn(rcdu->dev,
    "no encoder found for endpoint %pOF, skipping\n",
    ep->local_node);
    + of_node_put(entity);
    return -ENODEV;
    }

    --
    2.19.1
    \
     
     \ /
      Last update: 2019-03-27 20:02    [W:4.250 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site