lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v7 2/2] drivers/misc: Add Aspeed P2A control driver
    On Tue, Mar 12, 2019 at 09:31:01AM -0700, Patrick Venture wrote:
    > + phys_addr_t mem_base;

    Is this really a 32bit value?

    Your ioctl thinks it is:

    > +struct aspeed_p2a_ctrl_mapping {
    > + __u32 addr;

    Does this driver not work on a 64bit kernel?

    > + __u32 length;
    > + __u32 flags;
    > +};

    addr really should be __u32 here so you don't have to mess with 32/64
    bit user/kernel issues, right?

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2019-03-27 19:29    [W:3.209 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site