Messages in this thread | | | Date | Tue, 19 Mar 2019 17:12:30 +1100 | From | Stephen Rothwell <> | Subject | Re: [GIT PULL] Driver core patches for 5.1-rc1 |
| |
Hi Linus,
On Wed, 6 Mar 2019 15:47:11 -0800 Linus Torvalds <torvalds@linux-foundation.org> wrote: > > This is very funky, but that commit generates a new warning in a > totally unrelated area: > > drivers/iio/adc/qcom-pm8xxx-xoadc.c: In function ‘pm8xxx_xoadc_probe’: > drivers/iio/adc/qcom-pm8xxx-xoadc.c:633:8: warning: ‘ch’ may be used > uninitialized in this function [-Wmaybe-uninitialized] > ret = pm8xxx_read_channel_rsv(adc, ch, AMUX_RSV4, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > &read_nomux_rsv4, true); > ~~~~~~~~~~~~~~~~~~~~~~~ > drivers/iio/adc/qcom-pm8xxx-xoadc.c:426:27: note: ‘ch’ was declared here > struct pm8xxx_chan_info *ch; > ^~ > > I wonder why this wasn't seen in linux-next?
It is possible I missed it because I am currently building with -Wimplicit-fallthrough to help Kees and co with their attempt at making that a "normal" build flag for the kernel. Unfortunately it generates a few hundred warnings still.
-- Cheers, Stephen Rothwell [unhandled content-type:application/pgp-signature] | |