Messages in this thread | | | Subject | Re: [PATCH net] net: phy: Don't assume loopback is supported | From | Jose Abreu <> | Date | Mon, 18 Mar 2019 12:46:09 +0000 |
| |
Hi Andrew and Heiner,
On 3/17/2019 6:38 PM, Andrew Lunn wrote: > On Fri, Mar 15, 2019 at 03:48:41PM -0700, Florian Fainelli wrote: >> On 3/14/19 3:37 AM, Jose Abreu wrote: >>> Some PHYs may not support loopback mode so we need to check if register >>> is read-only. >>> >> >> In that case it may be appropriate to have a specific PHY driver that >> implements a set_loopback() method returning -EOPNOTSUPP instead of >> changing the generic PHY implementation. > > Hi Jose > > Since Heiner says this is a mandatory feature, we should not really > penalise conformant PHYs just because there is one broken PHY.
We provide PHYs to our customers and in the documentation I have this can be an optional feature that HW team can choose to have or not, making the bit read-only or r/w.
Heiner, can you please confirm there is no Clause 22 "pitfalls" / "hidden comments" that allow this bitfield to be read-only ?
Thanks, Jose Miguel Abreu
| |