Messages in this thread | | | Date | Mon, 18 Mar 2019 12:26:14 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH v2 4/6] leds: netdev trigger: move name length checking to netdev_trig_set_device |
| |
On Thu 2019-03-14 15:06:17, Rasmus Villemoes wrote: > It's better to check that size is sane in the function that does the > memcpy'ing and 0-termination to the IFNAMSIZ-sized buffer instead of > relying on callers getting it right. Not rejecting size upfront does > mean we would do the cancel_delayed_work_sync(), but that gets fixed > up by the set_baseline_state() call. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Exactly. 2,4:
Acked-by: Pavel Machek <pavel@ucw.cz>
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |