Messages in this thread | | | From | Stephen Boyd <> | Subject | Re: [PATCH v1 6/6] clk: hi6220: use CLK_OF_DECLARE_DRIVER | Date | Mon, 18 Mar 2019 13:21:29 -0700 |
| |
Quoting Peter Griffin (2019-03-18 12:38:51) > As now we also need to probe in the reset driver as well. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > drivers/clk/hisilicon/clk-hi6220.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Doesn't this need to be squashed with the reset driver bits so we don't have a bisection hole?
> > diff --git a/drivers/clk/hisilicon/clk-hi6220.c b/drivers/clk/hisilicon/clk-hi6220.c > index a87809d..952ffe2 100644 > --- a/drivers/clk/hisilicon/clk-hi6220.c > +++ b/drivers/clk/hisilicon/clk-hi6220.c > @@ -89,7 +89,7 @@ static void __init hi6220_clk_ao_init(struct device_node *np) > hisi_clk_register_gate_sep(hi6220_separated_gate_clks_ao, > ARRAY_SIZE(hi6220_separated_gate_clks_ao), clk_data_ao); > } > -CLK_OF_DECLARE(hi6220_clk_ao, "hisilicon,hi6220-aoctrl", hi6220_clk_ao_init); > +CLK_OF_DECLARE_DRIVER(hi6220_clk_ao, "hisilicon,hi6220-aoctrl", hi6220_clk_ao_init);
Can you also add a comment indicating why/what is the other driver that is probing the same device node?
| |