Messages in this thread | | | Date | Sun, 17 Mar 2019 11:13:39 +0100 | From | Steffen Klassert <> | Subject | Re: [PATCH] xfrm6_tunnel: Fix potential panic when unloading xfrm6_tunnel module |
| |
On Fri, Mar 15, 2019 at 02:24:38PM +0800, Herbert Xu wrote: > On Thu, Mar 14, 2019 at 02:59:42PM +0800, Su Yanjun wrote: > > When unloading xfrm6_tunnel module, xfrm6_tunnel_fini directly > > frees the xfrm6_tunnel_spi_kmem. Maybe someone has gotten the > > xfrm6_tunnel_spi, so need to wait it. > > > > Fixes: 91cc3bb0b04ff("xfrm6_tunnel: RCU conversion") > > Signed-off-by: Su Yanjun <suyj.fnst@cn.fujitsu.com> > > --- > > net/ipv6/xfrm6_tunnel.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > This looks good to me. And it's not just the matter of accessing > freed memory. A worse problem would be trying to execute code > from an unloaded module. > > Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks everyone!
| |