lkml.org 
[lkml]   [2019]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] IB/iser: remove uninitialized variable len
    From
    Date

    On 3/17/2019 1:05 AM, Colin King wrote:
    > From: Colin Ian King<colin.king@canonical.com>
    >
    > The variable len is not being inintialized and the uninitialized
    > value is being returned. However, this return path is never reached
    > because the default case in the switch statement returns -ENOSYS.
    > Clean up the code by replacing the return -ENOSYS with a break
    > for the default case and returning -ENOSYS at the end of the
    > function. This allows len to be removed. Also remove redundant
    > break that follows a return statement.
    >
    > Signed-off-by: Colin Ian King<colin.king@canonical.com>

    Looks good,

    Reviewed-by: Max Gurtovoy <maxg@mellanox.com>

    \
     
     \ /
      Last update: 2019-03-17 11:06    [W:3.448 / U:0.948 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site