lkml.org 
[lkml]   [2019]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v9 perf,bpf 04/15] perf, bpf: synthesize bpf events with bpf_program__get_prog_info_linear()
    Em Wed, Mar 13, 2019 at 06:00:30PM -0300, Arnaldo Carvalho de Melo escreveu:
    > Em Mon, Mar 11, 2019 at 10:30:40PM -0700, Song Liu escreveu:
    > > -
    > > /* Synthesize PERF_RECORD_KSYMBOL */
    > > for (i = 0; i < sub_prog_cnt; i++) {
    > > + u8 (*prog_tags)[BPF_TAG_SIZE] = (void *)(info->prog_tags);
    >
    > Need this:
    >
    > - u8 (*prog_tags)[BPF_TAG_SIZE] = (void *)(info->prog_tags);
    > + u8 (*prog_tags)[BPF_TAG_SIZE] = (u8 *)(info->prog_tags);
    >
    >
    > To overcome this on debian:experimental-x-mips, i.e. Debian Experimental
    > cross building to MIPS 32-bit:
    >
    > util/bpf-event.c: In function 'perf_event__synthesize_one_bpf_prog':
    > util/bpf-event.c:143:35: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    > u8 (*prog_tags)[BPF_TAG_SIZE] = (void *)(info->prog_tags);
    > ^
    > util/bpf-event.c:144:22: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    > __u32 *prog_lens = (__u32 *)(info->jited_func_lens);
    > ^
    > util/bpf-event.c:145:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    > __u64 *prog_addrs = (__u64 *)(info->jited_ksyms);
    > ^
    > util/bpf-event.c:146:22: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    > void *func_infos = (void *)(info->func_info);
    > ^
    > CC /tmp/build/perf/util/pmu.o
    > CC /tmp/build/perf/util/pmu-flex.o
    > cc1: all warnings being treated as errors

    Argh, hit the send button too fast, that is not the only case and then
    my change just changed the error:

    util/bpf-event.c: In function 'perf_event__synthesize_one_bpf_prog':
    util/bpf-event.c:143:35: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    u8 (*prog_tags)[BPF_TAG_SIZE] = (u8 *)(info->prog_tags);
    ^
    util/bpf-event.c:143:35: error: initialization of 'u8 (*)[8]' {aka 'unsigned char (*)[8]'} from incompatible pointer type 'u8 *' {aka 'unsigned char *'} [-Werror=incompatible-pointer-types]
    util/bpf-event.c:144:22: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    __u32 *prog_lens = (__u32 *)(info->jited_func_lens);
    ^
    util/bpf-event.c:145:23: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    __u64 *prog_addrs = (__u64 *)(info->jited_ksyms);
    ^
    util/bpf-event.c:146:22: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
    void *func_infos = (void *)(info->func_info);
    ^
    CC /tmp/build/perf/util/pmu.o
    CC /tmp/build/perf/util/pmu-flex.o
    cc1: all warnings being treated as errors
    mv: cannot stat '/tmp/build/perf/util/.bpf-event.o.tmp': No such file or directory

    \
     
     \ /
      Last update: 2019-03-13 22:09    [W:6.216 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site