Messages in this thread | | | Date | Fri, 15 Feb 2019 09:02:18 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [v4] coccinelle: semantic patch for missing put_device() |
| |
On Fri, 15 Feb 2019, Markus Elfring wrote:
> >> So I plan to modify the following to capture both cases: > >> -local idexpression id; > >> +expression id; > > > > I'm not sure that this is a good idea. > > Why have you got doubts here? > > > > There is likely no need for a put in the latter case. > > I have got understanding difficulties for such information. > What did you try to express with this sentence finally?
The whole goal of the semantic patch is to ensure that put_device is called when needed. If the value is stored in a structure, then someone else will likely take care of calling put_device later when the structure is destroyed.
julia
| |