Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 15 Feb 2019 19:12:45 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH 06/10] perf header: Fix wrong node write in NUMA_TOPOLOGY feature |
| |
On Wed, Feb 13, 2019 at 06:14:28PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Feb 13, 2019 at 06:09:43PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Feb 13, 2019 at 01:32:42PM +0100, Jiri Olsa escreveu: > > > We are currently passing the node index instead of the > > > real node number. > > > > Next time please add a Fixes: so that the stables guys get this thing... > > /me looking for that now. > > So this comes from: > > Fixes: fbe96f29ce4b ("perf tools: Make perf.data more self-descriptive (v8)" > > Right?
right, thanks
jirka
> > - Arnaldo > > > - Arnaldo > > > > > Link: http://lkml.kernel.org/n/tip-rbtlsr9ts23c89rki7d4s5sm@git.kernel.org > > > Signed-off-by: Jiri Olsa <jolsa@kernel.org> > > > --- > > > tools/perf/util/header.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c > > > index dec6d218c31c..7bebf9a34edd 100644 > > > --- a/tools/perf/util/header.c > > > +++ b/tools/perf/util/header.c > > > @@ -881,7 +881,7 @@ static int write_numa_topology(struct feat_fd *ff, > > > if (ret < 0) > > > break; > > > > > > - ret = write_topo_node(ff, i); > > > + ret = write_topo_node(ff, j); > > > if (ret < 0) > > > break; > > > } > > > -- > > > 2.17.2 > > > > -- > > > > - Arnaldo > > -- > > - Arnaldo
| ![\](/images/icornerr.gif) |