Messages in this thread | | | From | Ard Biesheuvel <> | Date | Fri, 15 Feb 2019 18:38:43 +0100 | Subject | Re: [PATCH 0/2] gcc-plugins: structleak: Generalize to all variable types |
| |
On Tue, 12 Feb 2019 at 19:04, Kees Cook <keescook@chromium.org> wrote: > > Instead of a new plugin for stack initialization[1], this improves > structleak to handle initialization of all variable types. Since the > instrumentation happens at a different point, the "switch" statement > changes from the earlier posting[2] are no longer needed. As before, > this also introduces a stack initialization regression testing module to > validate various kinds of stack variable usage vs compiler instrumentation > for initialization. See the individual patches for more details. >
For the series,
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
(although I reviewed 2/2 only cursorily)
> [1] https://lkml.kernel.org/r/CA+55aFykZL+cSBJjBBts7ebEFfyGPdMzTmLSxKnT_29=j942dA@mail.gmail.com > [2] https://lkml.kernel.org/r/20190123110349.35882-1-keescook@chromium.org > > Kees Cook (2): > gcc-plugins: structleak: Generalize to all variable types > lib: Introduce test_stackinit module > > lib/Kconfig.debug | 10 + > lib/Makefile | 1 + > lib/test_stackinit.c | 378 ++++++++++++++++++++++++ > scripts/Makefile.gcc-plugins | 2 + > scripts/gcc-plugins/Kconfig | 58 +++- > scripts/gcc-plugins/structleak_plugin.c | 36 ++- > 6 files changed, 463 insertions(+), 22 deletions(-) > create mode 100644 lib/test_stackinit.c > > -- > 2.17.1 >
| |