Messages in this thread | | | Date | Fri, 15 Feb 2019 08:45:02 -0800 | From | Stephen Hemminger <> | Subject | Re: [PATCH net] vhost: correctly check the return value of translate_desc() in log_used() |
| |
On Fri, 15 Feb 2019 15:53:24 +0800 Jason Wang <jasowang@redhat.com> wrote:
> When fail, translate_desc() returns negative value, otherwise the > number of iovs. So we should fail when the return value is negative > instead of a blindly check against zero. > > Reported-by: Stephen Hemminger <stephen@networkplumber.org> > Fixes: cc5e71075947 ("vhost: log dirty page correctly") > Signed-off-by: Jason Wang <jasowang@redhat.com>
Looks good. It is best to put the Addresses-Coverity-Id tag on these kind of bug fixes so that the automated tools see it.
| |