Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 15 Feb 2019 17:23:44 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH] net: phy: xgmiitorgmii: Support generic PHY status read |
| |
On Fri, Feb 15, 2019 at 05:17:08PM +0100, Paul Kocialkowski wrote: > Some PHY drivers like the generic one do not provide a read_status > callback on their own but rely on genphy_read_status being called > directly. > > With the current code, this results in a NULL function pointer call. > Call genphy_read_status instead when there is no specific callback. > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> > --- > drivers/net/phy/xilinx_gmii2rgmii.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c > index 74a8782313cf..bd6084e315de 100644 > --- a/drivers/net/phy/xilinx_gmii2rgmii.c > +++ b/drivers/net/phy/xilinx_gmii2rgmii.c > @@ -44,7 +44,10 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev) > u16 val = 0; > int err; > > - err = priv->phy_drv->read_status(phydev);
Hi Paul
How about using phy_read_status()?
Andrew
| ![\](/images/icornerr.gif) |