lkml.org 
[lkml]   [2019]   [Feb]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 05/11] mfd: pm8xxx: disassociate old virq if hwirq mapping already exists
    On Thu, Feb 14, 2019 at 09:51:26PM -0800, Stephen Boyd wrote:
    > > diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
    > > index 8eb2528793f9..2f99a98ccee5 100644
    > > --- a/drivers/mfd/qcom-pm8xxx.c
    > > +++ b/drivers/mfd/qcom-pm8xxx.c
    > > @@ -380,6 +380,12 @@ static void pm8xxx_irq_domain_map(struct pm_irq_chip *chip,
    > > struct irq_domain *domain, unsigned int irq,
    > > irq_hw_number_t hwirq, unsigned int type)
    > > {
    > > + unsigned int old_virq;
    > > +
    > > + old_virq = irq_find_mapping(domain, hwirq);
    > > + if (old_virq)
    > > + irq_domain_disassociate(domain, old_virq);
    >
    > Is it possible to pass 'true' for the 'realloc' argument to
    > __irq_domain_alloc_irqs() and then this disassociate change isn't
    > needed?

    The kernel doc for __irq_domain_alloc_irqs() says that the realloc
    parameter is mainly to support legacy IRQs. I don't think its a good
    idea to add new code that'll stay past the end of this patch series
    on top of that legacy interface.

    Brian

    \
     
     \ /
      Last update: 2019-02-15 14:49    [W:3.307 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site