Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 15 Feb 2019 10:37:16 +0100 | From | Cornelia Huck <> | Subject | Re: [PATCH v3 3/9] s390: ap: new vfio_ap_queue structure |
| |
On Thu, 14 Feb 2019 14:51:03 +0100 Pierre Morel <pmorel@linux.ibm.com> wrote:
> The AP interruptions are assigned on a queue basis > and we need some information neloging to the queue
s/neloging/belonging/
> to handle interuptions.
s/interuptions/interruptions/
> > We add a new structure vfio_ap_queue, to hold per > queue information useful to handle interruptions. > > - apqn: AP queue number (defined here) > - isc : Interrupt subclass (defined later) > - nib : notification information byte (defined later)
So, you basically simply want quick access to these? Makes sense.
> > The vfio_ap_queue structure is allocated when the vfio_ap_driver > is probed and added as driver data to the ap_queue device. > It is free on remove.
s/free/freed/
> > The structure is linked to the matrix_dev host device.
Hm, I don't quite follow?
> > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com> > Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com> > --- > drivers/s390/crypto/vfio_ap_drv.c | 23 ++++++++++++++++++++++- > drivers/s390/crypto/vfio_ap_private.h | 3 +++ > 2 files changed, 25 insertions(+), 1 deletion(-)
Patch looks reasonable; might make sense to squash it with later patches (still need to read).
| ![\](/images/icornerr.gif) |