Messages in this thread Patch in this message | | | Date | Fri, 15 Feb 2019 01:25:45 -0800 | From | tip-bot for Mathieu Poirier <> | Subject | [tip:perf/core] perf cs-etm: Add proper header file for symbols |
| |
Commit-ID: 859dcf64389c93a647f230a7cfd206d30bc9d286 Gitweb: https://git.kernel.org/tip/859dcf64389c93a647f230a7cfd206d30bc9d286 Author: Mathieu Poirier <mathieu.poirier@linaro.org> AuthorDate: Fri, 8 Feb 2019 15:35:43 -0700 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Thu, 14 Feb 2019 13:30:52 -0300
perf cs-etm: Add proper header file for symbols
After 'commit e22c1c751140 ("perf thread: Don't include symbol.h, symbol_conf.h is enough")'
Compilation of the perf tools is broken when using the functionality provided by the openCSD library:
[...]
... timerfd: [ on ] ... sched_getcpu: [ on ] ... sdt: [ OFF ] ... setns: [ on ] ... libopencsd: [ on ]
[...]
CC util/arm-spe.o CC util/arm-spe-pkt-decoder.o CC util/s390-cpumsf.o CC util/cs-etm.o CC util/parse-branch-options.o util/cs-etm.c: In function ‘cs_etm__mem_access’: util/cs-etm.c:297:24: error: storage size of ‘al’ isn’t known struct addr_location al;
And rightly so since file cs-etm.c doesn't include symbol.h, something that is rectified in this patch.
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Suzuki K Poulouse <suzuki.poulose@arm.com> Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/20190208223543.31836-1-mathieu.poirier@linaro.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/cs-etm.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 8b3f882d6e2f..0b11d653cfbe 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -25,6 +25,7 @@ #include "machine.h" #include "map.h" #include "perf.h" +#include "symbol.h" #include "thread.h" #include "thread_map.h" #include "thread-stack.h"
| |