Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH 4/4] dt-bindings: net: bluetooth: update broadcom-bluetooth | From | Marcel Holtmann <> | Date | Thu, 7 Nov 2019 15:09:48 +0100 |
| |
Hi Abhishek,
> Add documentation for pcm-parameters. > > Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org> > > --- > > Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > index c749dc297624..ae60277b5569 100644 > --- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > +++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.txt > @@ -29,6 +29,9 @@ Optional properties: > - "lpo": external low power 32.768 kHz clock > - vbat-supply: phandle to regulator supply for VBAT > - vddio-supply: phandle to regulator supply for VDDIO > + - pcm-parameters: When set, will configure PCM parameters on the device. The > + contents should be a 10-byte array corresponding to the pcm params (see > + btbcm.h for more information). > > > Example: > @@ -40,5 +43,6 @@ Example: > bluetooth { > compatible = "brcm,bcm43438-bt"; > max-speed = <921600>; > + pcm-parameters = [1 2 0 1 1 0 0 0 0 0]; > }; > };
I think about 1-2 years there have been a discussion on how to represent these values in a DT. I prefer we split these into separate values so it becomes usable by other drivers / vendors as well. In addition, maybe we start to focus on the values that differ from the default.
Regards
Marcel
| ![\](/images/icornerr.gif) |