Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [RFC v1 2/2] powerpc/pseries/iommu: Use dma_iommu_ops for Secure VMs aswell. | Date | Thu, 07 Nov 2019 21:26:28 +1100 |
| |
Ram Pai <linuxram@us.ibm.com> writes: > This enables IOMMU support for pseries Secure VMs.
Can you give us some more explanation please?
This is basically a revert of commit: edea902c1c1e ("powerpc/pseries/iommu: Don't use dma_iommu_ops on secure guests")
But neglects to remove the now unnecessary include of svm.h.
> diff --git a/arch/powerpc/platforms/pseries/iommu.c b/arch/powerpc/platforms/pseries/iommu.c > index 07f0847..189717b 100644 > --- a/arch/powerpc/platforms/pseries/iommu.c > +++ b/arch/powerpc/platforms/pseries/iommu.c > @@ -1333,15 +1333,7 @@ void iommu_init_early_pSeries(void) > of_reconfig_notifier_register(&iommu_reconfig_nb); > register_memory_notifier(&iommu_mem_nb); > > - /* > - * Secure guest memory is inacessible to devices so regular DMA isn't > - * possible. > - * > - * In that case keep devices' dma_map_ops as NULL so that the generic > - * DMA code path will use SWIOTLB to bounce buffers for DMA.
Please explain what has changed to make this no longer necessary.
cheers
> - */ > - if (!is_secure_guest()) > - set_pci_dma_ops(&dma_iommu_ops); > + set_pci_dma_ops(&dma_iommu_ops); > } > > static int __init disable_multitce(char *str) > -- > 1.8.3.1
| |