Messages in this thread | | | Date | Sun, 24 Nov 2019 18:18:02 -0500 | From | "Michael S. Tsirkin" <> | Subject | Re: [PATCH net-next v2] drivers: net: virtio_net: Implement a dev_watchdog handler |
| |
On Sun, Nov 24, 2019 at 03:03:52PM -0800, Jakub Kicinski wrote: > On Sun, 24 Nov 2019 16:48:35 -0500, Michael S. Tsirkin wrote: > > diff --git a/arch/m68k/emu/nfeth.c b/arch/m68k/emu/nfeth.c > > index a4ebd2445eda..8e06e7407854 100644 > > --- a/arch/m68k/emu/nfeth.c > > +++ b/arch/m68k/emu/nfeth.c > > @@ -167,7 +167,7 @@ static int nfeth_xmit(struct sk_buff *skb, struct net_device *dev) > > return 0; > > } > > > > -static void nfeth_tx_timeout(struct net_device *dev) > > +static void nfeth_tx_timeout(struct net_device *dev, int txqueue) > > Given the recent vf ndo problems, I wonder if it's worth making the > queue id unsigned from the start? Since it's coming from the stack > there should be no range checking required, but also signed doesn't > help anything so why not? > > > { > > dev->stats.tx_errors++; > > netif_wake_queue(dev);
You are right. I'll change this.
| |