lkml.org 
[lkml]   [2019]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v6 20/43] compat_ioctl: remove HIDIO translation
    Date
    The two drivers implementing these both gained proper compat_ioctl()
    handlers a long time ago with commits bb6c8d8fa9b5 ("HID: hiddev:
    Add 32bit ioctl compatibilty") and ae5e49c79c05 ("HID: hidraw: add
    compatibility ioctl() for 32-bit applications."), so the lists in
    fs/compat_ioctl.c are no longer used.

    It appears that the lists were also incomplete, so the translation
    didn't actually work correctly when it was still in use.

    Remove them as cleanup.

    Cc: linux-bluetooth@vger.kernel.org
    Cc: Marcel Holtmann <marcel@holtmann.org>
    Cc: Johan Hedberg <johan.hedberg@gmail.com>
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    fs/compat_ioctl.c | 17 -----------------
    1 file changed, 17 deletions(-)

    diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
    index 758b8b934b70..03da7934a351 100644
    --- a/fs/compat_ioctl.c
    +++ b/fs/compat_ioctl.c
    @@ -640,23 +640,6 @@ COMPATIBLE_IOCTL(PCIIOC_CONTROLLER)
    COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_IO)
    COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_MEM)
    COMPATIBLE_IOCTL(PCIIOC_WRITE_COMBINE)
    -/* hiddev */
    -COMPATIBLE_IOCTL(HIDIOCGVERSION)
    -COMPATIBLE_IOCTL(HIDIOCAPPLICATION)
    -COMPATIBLE_IOCTL(HIDIOCGDEVINFO)
    -COMPATIBLE_IOCTL(HIDIOCGSTRING)
    -COMPATIBLE_IOCTL(HIDIOCINITREPORT)
    -COMPATIBLE_IOCTL(HIDIOCGREPORT)
    -COMPATIBLE_IOCTL(HIDIOCSREPORT)
    -COMPATIBLE_IOCTL(HIDIOCGREPORTINFO)
    -COMPATIBLE_IOCTL(HIDIOCGFIELDINFO)
    -COMPATIBLE_IOCTL(HIDIOCGUSAGE)
    -COMPATIBLE_IOCTL(HIDIOCSUSAGE)
    -COMPATIBLE_IOCTL(HIDIOCGUCODE)
    -COMPATIBLE_IOCTL(HIDIOCGFLAG)
    -COMPATIBLE_IOCTL(HIDIOCSFLAG)
    -COMPATIBLE_IOCTL(HIDIOCGCOLLECTIONINDEX)
    -COMPATIBLE_IOCTL(HIDIOCGCOLLECTIONINFO)
    /* joystick */
    COMPATIBLE_IOCTL(JSIOCGVERSION)
    COMPATIBLE_IOCTL(JSIOCGAXES)
    --
    2.20.0
    \
     
     \ /
      Last update: 2019-10-09 21:15    [W:3.555 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site