Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 9 Oct 2019 21:58:07 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH 0/7] Fix various compilation issues with wfx driver |
| |
On Wed, Oct 09, 2019 at 03:13:14PM +0000, Jerome Pouiller wrote: > On Tuesday 8 October 2019 17:10:56 CEST Greg Kroah-Hartman wrote: > > On Tue, Oct 08, 2019 at 09:42:47AM +0000, Jerome Pouiller wrote: > > > From: Jérôme Pouiller <jerome.pouiller@silabs.com> > > > > > > Most of problems are related to big-endian architectures. > > > > kbuild still reports 2 errors with these patches applied: > > > > Regressions in current branch: > > > > drivers/staging/wfx/hif_tx.c:82:2-8: preceding lock on line 65 > > As I replied to Julia, this behavior is intended. > > > drivers/staging/wfx/main.c:188:14-21: ERROR: PTR_ERR applied after initialization to constant on line 183 > > This is a false positive, as confirmed by Dan. > > You may also notice: > > drivers/staging/wfx/scan.c:207 wfx_scan_work() warn: inconsistent returns 'sem:&wvif->scan.lock' > > I also consider it as a false positive.
Yeah. I thought it might be. The beauty of 0day bot is that normally the warnings come really quick after the original author wrote the code so it's fresh in their heads. I suspected it might be a false positive but I wasn't sure either way and I try not to spend a lot of time reviewing those warnings.
regards, dan carpenter
| ![\](/images/icornerr.gif) |