lkml.org 
[lkml]   [2019]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 4/8] recordmcount: Rewrite error/success handling
    On Wed, Oct 09, 2019 at 11:05:38AM -0400, Steven Rostedt wrote:
    > On Wed, 9 Oct 2019 12:46:26 +0200
    > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
    >
    >
    > > uwe@taurus:~/arietta/kbuild$ ./scripts/recordmcount "arch/arm/crypto/aes-cipher-glue.o"
    > > arch/arm/crypto/aes-cipher-glue.o: failed
    >
    > Thanks for the report.
    >
    > >
    > > I didn't debug this further, if you have problems reproducing or need more
    > > infos tell me. The defconfig I'm using is attached.
    > >
    >
    > Does this fix it for you?
    >
    > -- Steve
    >
    > diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
    > index 3796eb37fb12..6dbec46b7703 100644
    > --- a/scripts/recordmcount.h
    > +++ b/scripts/recordmcount.h
    > @@ -389,11 +389,8 @@ static int nop_mcount(Elf_Shdr const *const relhdr,
    > mcountsym = get_mcountsym(sym0, relp, str0);
    >
    > if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
    > - if (make_nop) {
    > + if (make_nop)
    > ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
    > - if (ret < 0)
    > - return -1;
    > - }

    Yes, this patch fixes building for me.

    Best regards
    Uwe

    --
    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | http://www.pengutronix.de/ |

    \
     
     \ /
      Last update: 2019-10-09 17:22    [W:9.130 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site