lkml.org 
[lkml]   [2019]   [Oct]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/10] media: renesas-ceu: Use of_device_get_match_data()
    Em Fri,  4 Oct 2019 14:43:26 -0700
    Stephen Boyd <swboyd@chromium.org> escreveu:

    > This driver can use the replacement API instead of calling
    > of_match_device() and then dereferencing the pointer that is returned.
    > This nicely avoids referencing the match table when it is undefined with
    > configurations where CONFIG_OF=n.
    >
    > Cc: Arnd Bergmann <arnd@arndb.de>
    > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    > Cc: Jacopo Mondi <jacopo@jmondi.org>
    > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
    > Cc: Rob Herring <robh+dt@kernel.org>
    > Cc: Frank Rowand <frowand.list@gmail.com>
    > Cc: <linux-media@vger.kernel.org>
    > Cc: <linux-renesas-soc@vger.kernel.org>
    > Signed-off-by: Stephen Boyd <swboyd@chromium.org>
    > ---
    >
    > Please ack or pick for immediate merge so the last patch can be merged.

    Feel free to merge it via your tree:

    Acked-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>


    >
    > drivers/media/platform/renesas-ceu.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/media/platform/renesas-ceu.c b/drivers/media/platform/renesas-ceu.c
    > index 197b3991330d..60518bbc2cd5 100644
    > --- a/drivers/media/platform/renesas-ceu.c
    > +++ b/drivers/media/platform/renesas-ceu.c
    > @@ -1679,7 +1679,7 @@ static int ceu_probe(struct platform_device *pdev)
    > v4l2_async_notifier_init(&ceudev->notifier);
    >
    > if (IS_ENABLED(CONFIG_OF) && dev->of_node) {
    > - ceu_data = of_match_device(ceu_of_match, dev)->data;
    > + ceu_data = of_device_get_match_data(dev);
    > num_subdevs = ceu_parse_dt(ceudev);
    > } else if (dev->platform_data) {
    > /* Assume SH4 if booting with platform data. */



    Thanks,
    Mauro

    \
     
     \ /
      Last update: 2019-10-09 14:55    [W:3.109 / U:0.276 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site